search

mtytel / helm

Helm - a free polyphonic synth with lots of modulation
http://tytel.org/helm
GNU General Public License v3.0
2.34k stars 201 forks source link

Opening the Helm GUI from MusE sometimes freezes Helm #273

Open bluebear94 opened 3 years ago

bluebear94 commented 3 years ago

To reproduce: create new synth track, open native GUI. Doesn't always happen; might need several tries to reproduce. Might be related to #247 or #223.

xard-dev commented 3 years ago

Have you opened any other instruments before opening Helm?

I noticed that if I open 2.0 version of OB-Xd (which uses 3d acceleration) before helm it crashes when trying to open the GUI and vice versa in Ardour and Carla.

bluebear94 commented 3 years ago

It doesn't seem to freeze when I haven't opened any other synth GUIs earlier, although they don't necessarily have to be from a different instrument.

xard-dev commented 3 years ago

In my case not all instruments cause issues but I suspect that the JUCE Opengl does something weird in here.

Helm 0.9.0 has couple of years old version of JUCE and I'd wonder how huge task it would be to get it compiling on newer version.

Though even compiling the binaries again might shed some light into the situation or at least enable debugging if nothing else.

xard-dev commented 3 years ago

I found out that there is a LV2 port JUCE 5.4.7 available and managed to update the Helm 0.9.0 code base to run on it: No more crashes.

bluebear94 commented 3 years ago

Nice, perhaps put a PR here? @mtytel doesn't seem to be very active nowadays, though.

xard-dev commented 3 years ago

I should probably do that but currently the local repository is a mess after trying various approaches to deal with JUCE after finally caving to just update it and leave all debug changes on.

Otherwise after refactoring needed places all over the source it complains without separate GCC patches but I haven't tested VST compilation yet.

xard-dev commented 3 years ago

Okay, pull requestion done: @bluebear94 it would be nice to hear if this fixes anything for you if you can / are willing to / have time to compile and test it.

tmewett commented 3 years ago

I'm also getting crashes - not in MusE, in REAPER, though I think it may be the same cause as this bug.

Have you opened any other instruments before opening Helm?

I experience the crash when VST Helm and Sitala are opened in the same session. Seems you're right in your assessment - both probably have process-global state and clash when both loaded in the DAW process.

Fortunately REAPER lets you run specific plugins in separate processes, so I can just do that with Sitala and it works fine. If you're getting this issue, see if your DAW can do the same.