Under Windows 10 Professional 21H2 19044.1766 AMD64, maximizing Helm at 3440x1440 (100% scaling in Windows) resolution results in the Legato and Porta-Type labels clipping off the edge of the panel they display within.
This appears to occur regardless of the display height. I am guessing these labels may just have layout boundaries that are slightly misconfigured, since other similar controls on the display seem to not have this issue.
Taking a look at the source code, I spotted what appears to be the code to define this:
My (very uninformed and probably wrong) guess here is that portamento_ is not adding the extra_text_space attribute, but portamento_type_ and legato_ both are, and this might not be necessary? Even if I try to coerce the window to fill to a portrait aspect ratio, I cannot get a situation where that extra_text_space does anything.
Screenshot of window on 1440x2560 monitor (portrait aspect ratio)
Would removing that extra_text_space entirely resolve this? If so, I can always put a PR up to fix this?
Screenshot of the issue
Under Windows 10 Professional 21H2 19044.1766 AMD64, maximizing Helm at 3440x1440 (100% scaling in Windows) resolution results in the Legato and Porta-Type labels clipping off the edge of the panel they display within.
This appears to occur regardless of the display height. I am guessing these labels may just have layout boundaries that are slightly misconfigured, since other similar controls on the display seem to not have this issue.
Taking a look at the source code, I spotted what appears to be the code to define this:
dynamic_section.cpp
In another file, I seem to have spotted a similar thing, but it is configured slightly differently:
voice_section.cpp
My (very uninformed and probably wrong) guess here is that
portamento_
is not adding theextra_text_space
attribute, butportamento_type_
andlegato_
both are, and this might not be necessary? Even if I try to coerce the window to fill to a portrait aspect ratio, I cannot get a situation where thatextra_text_space
does anything.Screenshot of window on 1440x2560 monitor (portrait aspect ratio)
Would removing that
extra_text_space
entirely resolve this? If so, I can always put a PR up to fix this?