search

mtytel / vital

Spectral warping wavetable synth
GNU General Public License v3.0
1.55k stars 152 forks source link

Please release custom JUCE changes as standalone repo #16

Open falkTX opened 3 years ago

falkTX commented 3 years ago

Hi there. While packaging vital as vitalium, I noticed that there are a few issues present on the custom version that are not in the original. I was told there is at least this patch applied in vital https://gist.github.com/wrl/240050fd46e14b688551c75ed2700076 There is also custom APIs that you added on top of JUCE.

Issue is, it is very hard at the moment to know what changes you made, much less reasons for doing so. Please consider making a repo for tracking your juce changes. Or better, as I expect you do already have such a repo, please make it public. Thanks

mtytel commented 3 years ago

Ehh... yeah I can release this. I'll need a bit to make sure there aren't changes that can't be public but I think it's fine. I really tried keeping JUCE intact but at some point there were things I had to change to make my UI system work.

falkTX commented 3 years ago

Thank you. I considered checking out the changes manually, but on 2nd thought it seems like it will be really tough, plus I wont really understand any reason why something was changed.