mtzgroup / chemcloud-client

Python client for TeraChem Cloud
MIT License
11 stars 3 forks source link

[FEATURE] Rethink _RequestClient public compute() and results() method #11

Open coltonbh opened 3 years ago

coltonbh commented 3 years ago

When I need to change an http method I currently have to change it in two places--the _RequestsClient and the TCClient where the truly public method lives that end users call. This two-layer deep nesting of methods is probably a bad idea. Maybe .request() and .authenticated_request() should be the public methods with all serialization to python objects happening in the TCClient alone.

See my notes in /docs re: this architectural choice before. Probably good to retire the previous thinking in favor or this.