mu-editor / mu

A small, simple editor for beginner Python programmers. Written in Python and Qt5.
http://codewith.mu
GNU General Public License v3.0
1.42k stars 437 forks source link

Add sparkfun samd51 thing plus - circuitpython #1087

Closed nezra closed 4 years ago

nezra commented 4 years ago

If you are reporting a bug, we would like to know:

Use the sparkfun samd51 thing plus with circuitpython installed

Attempted to connect via repl, also via circuit python

Works.

No device attached error message

Doesn't work.

Please remember to attach a copy of the full log files for Mu. You can get the logs by clicking on the cog icon in the bottom right of the editor window. Click on the logs and use CTRL-A to select all, then CTRL-C to copy and CTRL-V to paste the contents into the issue.

Thank you for contributing to Mu! :-)

In short, the modes definition under circuitpython is missing the device. It needs the following added:

PID: 0x0016 VID: 0x1b4f

Spark fun thing plus SAMD51

dybber commented 4 years ago

Thanks for reporting this, it's not easy to keep tab on all the new devices which are manufactured.

I've added it to #1094, and should be working in the next version of Mu. Here's a direct link to the commit: https://github.com/mu-editor/mu/pull/1094/commits/47f8bbeff812a822598c44f5381257be500df12a

carlosperate commented 4 years ago

I'll close this issue as https://github.com/mu-editor/mu/pull/1094 has been merged 🎉