mu-editor / mu

A small, simple editor for beginner Python programmers. Written in Python and Qt5.
http://codewith.mu
GNU General Public License v3.0
1.41k stars 435 forks source link

CI: Workaround CodeQL pip install issues by changing Ubuntu version. #2367

Closed carlosperate closed 1 year ago

carlosperate commented 1 year ago

I'm not too sure why in the GH Actions runner ubuntu-latest, which has been recently updated from 20.04 to 22.04, the pip resolver struggles to download wheels and (when given some help by manually installing some subdependencies at a version we know should work) it ends up with a large recursion of trying to find dependency versions that match all requirements.

And when ubuntu-latest is used with the Python Github Action it does work, not sure why the default system Python/pip fails.

So, specifying ubuntu-20.04 as the runner resolves/worksaround the issue. Also, as we will be updating the Mu dependencies soon, there is not much point spending more time on this unless it starts affecting users pip installing Mu.

carlosperate commented 1 year ago

@ntoll @tjguk this is the last PR to get the CI back to all green, so I'll merge as soon as all the tests pass, and any work in progress can be rebased to get a more accurate CI pass/fail output.

tjg-global commented 1 year ago

Definite +1 from me. Thanks, @carlosperate

carlosperate commented 1 year ago

Great, merging now! 🎉