search

mu-editor / mu

A small, simple editor for beginner Python programmers. Written in Python and Qt5.
http://codewith.mu
GNU General Public License v3.0
1.41k stars 435 forks source link

Fixes #2315 #2377

Closed haikusw closed 1 year ago

haikusw commented 1 year ago

This fixes issue #2315 and allows reducing the window size down to the minimum size.

Verified works on macOS 10.13.16 and the built and packaged app works on macOS 12.6.1. make check comes up all clean.

tjguk commented 1 year ago

Thanks; I'm happy to merge this, although I realised while taking it through its paces that we need to have a bit of a rethink about our story on screen geometry and positioning; we're a bit all over the place. However I don't think this change interferes with that, even if it might later be overtaken by events.

haikusw commented 1 year ago

Thanks; I'm happy to merge this, although I realised while taking it through its paces that we need to have a bit of a rethink about our story on screen geometry and positioning; we're a bit all over the place. However I don't think this change interferes with that, even if it might later be overtaken by events.

Thanks. What I realized, and why I backed out the screensize // 2 deletion in my last commit, is that the app actually needs to potentially work across a very large range of display sizes - from quite small (pi with a 5" TFT?" to wide screen displays like the one I'm currently on (49", 5120 x 1440) and that requires care in design and coding to not cause poor utility and experience for the full range.

I also thought about how it might be nice to have it be a better macOS app and include the usual macOS menus with commands matching the existing toolbar buttons and including other default behaviors (cut/copy/paste etc). But I'm not in a position to get into Qt at that level currently.