mu-editor / mu

A small, simple editor for beginner Python programmers. Written in Python and Qt5.
http://codewith.mu
GNU General Public License v3.0
1.39k stars 433 forks source link

Duplicate code found: let's refactor it! #2445

Open tmontes opened 1 year ago

tmontes commented 1 year ago

What were you trying to do?

EP 2023 Sprints Czech translation

What steps did you take to trigger the issue?

The info message in mu/logic.py:1730 -- This name is already used by another part of Python... -- is repeated in line 1295.

These are codepaths that protect the user from saving files with "funky" names... Found in the save and rename_tab methods of the Editor class.

Thanks @prochazka-jan for finding it!

What did you expect to happen?

No code duplication? :)

What actually happened?

No response

Operating System Version

No response

Mu Version

Latest master.

Other Info

No response

Editor Log

No response

SurajSanap commented 8 months ago

fixed #2481.