A MagicMock object was being asserted with called_once_with() instead of assert_called_once_with(), likely an accidental mistake.
As a MagicMock always returns another instance of MagicMock on anything not previoysly set up, the assert was always passing, even though we updated the Window.connect_zoom() implementation and these asserts should be failing.
I only noticed this because in Python 3.12 this type of typo is caught and throws an exception.
A MagicMock object was being asserted with
called_once_with()instead ofassert_called_once_with(), likely an accidental mistake.As a MagicMock always returns another instance of MagicMock on anything not previoysly set up, the
assertwas always passing, even though we updated theWindow.connect_zoom()implementation and these asserts should be failing.I only noticed this because in Python 3.12 this type of typo is caught and throws an exception.