On Windows, screen reader reads lines out of turn

mu-editor / mu

A small, simple editor for beginner Python programmers. Written in Python and Qt5.

http://codewith.mu

GNU General Public License v3.0

1.41k stars 435 forks source link

On Windows, screen reader reads lines out of turn #523

Open ntoll opened 6 years ago

ntoll commented 6 years ago

This has been demonstrated on more than one screen reader. This doesn't appear to happen when the file that's being edited has been loaded from the file system. I.e. it only works with tabs that were originally created from new.

Steps to reproduce:

Open new tab
Type the following:

Move between lines using down and up arrow keys.
Screen reader will say things like "1, 2" instead of "1".

tjguk commented 6 years ago

Line-endings?

ZanderBrown commented 6 years ago

@tjguk that seems so simple and obvious it may just be the problem :smile:

dumbledad commented 6 years ago

I had a quick try with SciTE to see if it was a Scintilla problem but I am not seeing the same error there.

tjguk commented 6 years ago

Nice idea. Unfortunately the QScintilla control we're using is a complete re-implementation of the Scintilla control, not merely a wrapper!

dumbledad commented 6 years ago

Ah. back to the drawing board. I'd like to find out the minimal way of deciding if it's a bug with mu or QScintilla (or NVDA)

tjguk commented 6 years ago

If you haven't: could you try saving the file, please, and then trying again? Or: can you confirm whether the behaviour is at all different with:

A new and unsaved file
A new and saved file
An existing file which has been opened

The reason for these questions is that we have some slightly fiddly line-ending code going on when saving or opening and since this looks a bit like a line-ending issue I'd like to know if there's any likely interaction.

dumbledad commented 6 years ago

It's not you.

If I make a simple QScintilla editor in python using the example code here I get exactly the same bug. I'll work out where to submit that and post a link here.

But to answer your question it fails on the first and second option, but not the third. I.e. new file = fail, new saved file = fail, file loaded from disk = no fail.

tjguk commented 6 years ago

Ah. Good catch, then. Hopefully it'll be something Nice and Easy [tm] for the PyQt guys and they'll be able to post an updated wheel Real Soon [tm] for us to update to.

Thanks for working this through for us.

dumbledad commented 6 years ago

I'm not entirely sure where to post QScintilla bug reports, so I've put it on their mailing list here: https://riverbankcomputing.com/pipermail/qscintilla/2018-July/001318.html

dumbledad commented 6 years ago

I heard back from Phil Thompson at Riverbank Computing. He asked if I could try tonight's QScintilla snapshot. I don't think I am going to get time to attend to this soon, so if anyone has a working Mu build, NVDA, and access to the QScintilla snapshots please take a look. He suggested that the problem isrelatedto CR-LF line endings. and that if that is the case Mu could set the EOL mode to EOLUnix on all platforms.

devdanzin commented 3 years ago

Cannot reproduce on current master and fresh installed NVDA. Also tried a simple QScintilla editor example, no mistakes. But if I press the right arrow at the end of a line, NVDA will read "carriage return" or "line feed".

Not sure whether QScintilla changed, NVDA special-cases the previous issue, or my environment isn't representative of the ones where the problem shows up.