search

mu-editor / mu

A small, simple editor for beginner Python programmers. Written in Python and Qt5.
http://codewith.mu
GNU General Public License v3.0
1.41k stars 437 forks source link

Code checker reports too many whitespace errors #917

Open martybillingsley opened 5 years ago

martybillingsley commented 5 years ago

The Check command reports too many irrelevant issues when checking Python code. The whitespace comments, which Python doesn't care about, make it very difficult for beginning coders to see actual syntax errors.

For example: x=1 is legal Python, yet the check reports "Missing whitespace around operator"

This issue was raised -- and closed -- in June 2018, but the latest Mu download doesn't include the fix.

Any way we can configure Mu so the check feature reports only syntax errors?

tjguk commented 5 years ago

Per my comment on gitter, I think that the addition of the [Tidy] button (invoking Black [1]) means that we can now disable layout-only checking on the [Check] button, leaving only the syntax / semantic issues.

My experience with youngsters is that their code is sufficiently untidy that pressing [Check] means they're bewildered by an array of "you've got the wrong amount of space..." messages and miss the essential "You haven't defined this name" messages.

I'll assign to myself with a view to a PR for feedback. @martybillingsley, feel free to prepare a change yourself. If you'd like to, and need guidance on the codebase, please ask back here.

[1] https://github.com/psf/black