search

mu-semtech / mu-javascript-template

Template for running javascript/express microservices
4 stars 17 forks source link

production build ignores additions in package.json #29

Open nvdk opened 3 years ago

nvdk commented 3 years ago

Currently the production build ignores any additions that are made in the app's package.json file. Dependencies are installed, but any addition to script or other configuration for packages that typically resides in package.json is not taken into account.

It could be argued this is by design and extra scripts and configuration should not be available when running in production mode, but it does feel like a limitation. Perhaps merging the package.json file of the app and a template is a more flexible approach?

nvdk commented 3 years ago

The approach in https://github.com/mu-semtech/mu-javascript-template/pull/30 seems to work quite well, though it should probably be tested a bit more.

erikap commented 2 years ago

Is this still the case on v1.6.0?

nvdk commented 1 year ago

this is still the case in 1.7.0, because we start the app from the package.json in mu-javascript-template the scripts are not found when running npm run xxx