mu-semtech / mu-javascript-template

Template for running javascript/express microservices
4 stars 17 forks source link

Container enhancement #4

Closed cecton closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 97.01%

Merging #4 into master will not change coverage

@@             master         #4   diff @@
==========================================
  Files             2          2          
  Lines            67         67          
  Methods           7          7          
  Messages          0          0          
  Branches          7          7          
==========================================
  Hits             65         65          
  Misses            2          2          
  Partials          0          0          

Powered by Codecov. Last updated by 1e22c83...b6fc6a1

erikap commented 8 years ago

@cecton: it's not intended to include the mu.semte.ch stack in each template. We already have mu-project to bootstrap a mu.semte.ch project. This repository should just have a dockerized template which can be easily extend by users to build a custom microservice. Have a look at mu-ruby-template as an example.

cecton commented 8 years ago

Okay thanks. The idea here was to give a fully working example... but it's true it's a bit too much for a template repository. You have a reference to a host "database" in the Dockerfile of mu-ruby-template but it's not defined anywhere.