search

muak / AiForms.Effects

AiForms.Effects for Xamarin.Forms
MIT License
245 stars 27 forks source link

AddCommand.SyncCanExecute does not work on Android #53

Closed alexpetin closed 4 years ago

alexpetin commented 4 years ago

Hi! Thanks for this must-have lib! It would be great to fix SyncCanExecute on Android, on iOS - it works well.

alexpetin commented 4 years ago

And it would be even more great to have possibility to somehow separate setting of IsEnabled and Opacity on sync - it would allow to customise disabled effect...

muak commented 4 years ago

@alexpetin I regret to say that I couldn't reproduce it. It works fine on my environment. Could you show more detail?

About settings of IsEnabled and Opacity, I consider it.

alexpetin commented 4 years ago

Sorry, I had to be more detailed. On Android the tap effect occurs for disabled by SyncCanExecute items.

muak commented 4 years ago

@alexpetin Sorry, I can't reproduce it. Could you offer a minimum reproducible project?

alexpetin commented 4 years ago

@muak TestEffects.zip Video.zip

muak commented 4 years ago

@alexpetin Thank you for your project files.

I fixed and released it.

Thanks!