archlinux mkchromecast-git package targets unstable `master` branch

xsdg commented 10 months ago

Issue #445 fundamentally results from the fact that I'm in the middle of a large refactor/rewrite of the project, which will unavoidably destabilize the mkchromecast codebase. I think the best approach would be for the aur package to target a more stable branch, potentially with some option for users to point it at the master branch, with the understanding that there's a risk of HEAD being broken.

@benjamb , are you the same person as the benjamb who maintains https://aur.archlinux.org/packages/mkchromecast-git ?

benjamb commented 10 months ago

I am indeed. -git suffixed packages are development versions of those without the suffix, so it's expected that there will be some instability. After a quick search however, it does appear the stable package no longer exists, so I could create that.

Is there a commit that could be tagged that's more recent than 0.3.8.1 that was released over 6 years ago, but before your recent refactoring.

xsdg commented 10 months ago

I don't think there's a specific conclusive answer, but here are some datapoints:

Debian (unstable through stable) and Ubuntu ship a package based off db2964a1 Updated qt and clean targets on Makefile.; see https://salsa.debian.org/debian/mkchromecast.git . I figure this will be the most-tested version.
It looks like you have a PR that was merged after that commit, c046ba2f Merge pull request #376 from benjamb/benbrown/list-regex. I presume you would want this in the stable aur package
There were some (automated?) minimal-version bumps after your PR, leading up to the commit 10b91bd4 Merge pull request #409 from muammar/dependabot/npm_and_yarn/nodejs/qs-and-express-6.11.0 from Dec 2022.

I'm open to other ideas and suggestions, but I would be comfortable with creating a stable branch that points to any of those three commits. That said, I don't think I have enough of a grasp on how the project metadata works (or how correct it is) just yet to actually create a new release.

xsdg commented 10 months ago

@andrewshadura @bgermann FYI, re: the Debian mkchromecast package

benjamb commented 10 months ago

Something with at least a35a5d9673b140c6ce57a5ada21556147d259762 would be preferable, since it includes various patches (not just my own) to make it pipewire friendly.

xsdg commented 10 months ago

Okay, I created a stable branch (currently) pointing at the merge commit for the commit you referenced: https://github.com/muammar/mkchromecast/tree/stable

muammar / mkchromecast

archlinux mkchromecast-git package targets unstable `master` branch #446