muammar / mkchromecast

Cast macOS and Linux Audio/Video to your Google Cast and Sonos Devices

http://mkchromecast.com

Other

2.22k stars 140 forks source link

Updates `imp` import to `importlib` for compatibility with Python 3.12 #465

Closed psmgeelen closed 6 months ago

psmgeelen commented 6 months ago

Scope

Fixes #464

What is changed

mkchromecast/tray_threading.py refers to imp that is no longer supported in python 3.12. This has been changed to importlib. Initial testing shows that it is working.

xsdg commented 6 months ago

Looks reasonable! In general, the PR title should be independently meaningful without needing to look up other references to make sense of it. Referring to related bugs in the PR description is sufficient.

Also, specifically in github, if you use a statement like "fixes #464 " in the description (I don't know if it also works in comments or not), that will cause that bug to be automatically marked as fixed when the PR is merged.