Use electron-builder to generate install packages

muan / mojibar

:tangerine: Emoji searcher but as a menubar app.

MIT License

2.05k stars 124 forks source link

Use electron-builder to generate install packages #81

Open krolow opened 7 years ago

krolow commented 7 years ago

I was working in PR #78 while doing that I'd like to get a .deb package, so I made some changes in the code to have a electron-builder working together instead of electron-packager.

I'd like to know if it is something that would be valuable for the project, so I can work in some PR?

To achieve that... It would involve to have a linux to build to (win/linux) for that I can setup a docker-compose that would do the build in a mac env...

For mac it adds the dmg installer that can have some icon to install/background and other things... not sure if we do have some art for those things or can I set some default one...

let me know what do you think about...

muan commented 7 years ago

Thanks @krolow. I'm not very familiar with electron-builder, but from the looks of it I thought it should take care of most things we need, why the following is needed?

To achieve that... It would involve to have a linux to build to (win/linux) for that I can setup a docker-compose that would do the build in a mac env...

To get start with this, since this feature is for .deb, we haven't gotten requests for .dmg, and full Windows support isn't added yet, I think we can punt on the mac/win installer for now (keep using electron-packager for them). Also perhaps could you let me know why an installer is preferred?

krolow commented 7 years ago

so it's more a "comfortable" way to install... it would be possible to release the .tar.gz .deb .rpm in the github releases, and we could have a link point to it in README, so people just download the .deb for example and do "dpkg -i mojibar.deb" and we get it installed...

It would allow as well to put it in some apt repository, so in some future we could enable "apt-get install mojibar" from ubuntu/debian directly...

We could leave like it is in #78 but it would involve someone clone the repo, install the deps and run the build... it would take a bit more of time as in linux we don't have a homebrew thing to install directly...

And in linux we do not have Command + Control + Spacebar to get emoji list, so if we do have a release/and/maybe add it in some apt repository, we can get more people using mojibar

krolow commented 7 years ago

It also generate the "configuration" necessary to have a gnome app for example, I have used electron-builder here to build a .deb file so that I can install.. this is how it looks like in gnome-shell