muaz-khan / RecordRTC

RecordRTC is WebRTC JavaScript library for audio/video as well as screen activity recording. It supports Chrome, Firefox, Opera, Android, and Microsoft Edge. Platforms: Linux, Mac and Windows.
https://www.webrtc-experiment.com/RecordRTC/
MIT License
6.58k stars 1.76k forks source link

Fix/web assembly recorder #615

Closed jonklein closed 4 years ago

jonklein commented 4 years ago

Several fixes & improvements for issues I found in using WebAssemblyRecorder:

thijstriemstra commented 4 years ago

can you add a new release with this @muaz-khan?

thijstriemstra commented 4 years ago

@jonklein did you test this with Firefox and polyfill, e.g. the online demo? https://www.webrtc-experiment.com/RecordRTC/simple-demos/WebAssemblyRecorder.html

18:14:32.051 TypeError: The stream is not in a state that permits enqueue
readable-stream.ts:1274:12
    enqueue readable-stream.ts:1274
    f RecordRTC.js:6008

It breaks the demo (and my project relying on recordrtc) so I have to revert back to recordrtc 5.5.9 for now unfortunately.

cc @muaz-khan

thijstriemstra commented 4 years ago

screenshot: Screenshot from 2020-05-17 18-16-51

muaz-khan commented 4 years ago

@thijstriemstra Please check https://github.com/muaz-khan/RecordRTC/commit/1fd3e0304c0b4b72ea37b644cbe40efa9f0e654e . And test demo again on Firefox.

thijstriemstra commented 4 years ago

thanks @muaz-khan looks good now.