Closed jonklein closed 4 years ago
can you add a new release with this @muaz-khan?
@jonklein did you test this with Firefox and polyfill, e.g. the online demo? https://www.webrtc-experiment.com/RecordRTC/simple-demos/WebAssemblyRecorder.html
18:14:32.051 TypeError: The stream is not in a state that permits enqueue
readable-stream.ts:1274:12
enqueue readable-stream.ts:1274
f RecordRTC.js:6008
It breaks the demo (and my project relying on recordrtc) so I have to revert back to recordrtc 5.5.9 for now unfortunately.
cc @muaz-khan
screenshot:
@thijstriemstra Please check https://github.com/muaz-khan/RecordRTC/commit/1fd3e0304c0b4b72ea37b644cbe40efa9f0e654e . And test demo again on Firefox.
thanks @muaz-khan looks good now.
Several fixes & improvements for issues I found in using WebAssemblyRecorder:
fix audio feedback: set video element to muted
fix truncated video content: don't terminate the worker immediately, wait for the final message indicating that encoding is complete
fix video timescale not matching framerate: use setInterval instead of repeated setTimeouts to make sure frames are timed correctly instead of slipping
add a
onVideoProcessStarted
callback, which is useful for better synchronization of audio/video from different recordersadd
realtime
flag, defaulted to true (current behavior), to allow for non-realtime (higher quality) encoding. this is very slow, but may be useful.