search

muaz-khan / RecordRTC

RecordRTC is WebRTC JavaScript library for audio/video as well as screen activity recording. It supports Chrome, Firefox, Opera, Android, and Microsoft Edge. Platforms: Linux, Mac and Windows.
https://www.webrtc-experiment.com/RecordRTC/
MIT License
6.49k stars 1.75k forks source link

Ensure Recorder is mounted in `handleRecordingDuration` function #764

Open angekouf opened 2 years ago

angekouf commented 2 years ago

I have added a check in the handleRecordingDuration function to make sure the Recorder is still mounted when the callback to the setTimeout is called.

This is needed because if the Recorder is unmounted after the recording ends and the user stops the recording before reaching the time limit, then an error occurs since self is null . image

angekouf commented 2 years ago

This solves issue #728

damiaanh commented 8 months ago

Bump as I still have this issue. Can we merge the commit?

jur-ng commented 8 months ago

LGTM @muaz-khan

angekouf commented 6 months ago

I have rebased the branch to use the latest version of the repo @muaz-khan

PibeG commented 5 months ago

This would be great, can't use setRecordingDuration because of this

damiaanh commented 4 months ago

@muaz-khan Are you still maintaining this repo?