search

muaz-khan / WebRTC-Experiment

WebRTC, WebRTC and WebRTC. Everything here is all about WebRTC!!
https://www.webrtc-experiment.com/
MIT License
11.75k stars 3.95k forks source link

some small issues on desktop-capturing #178

Open alberttsai opened 10 years ago

alberttsai commented 10 years ago

Dear Muaz, I have applied the fix of #174 to desktop-capturing.js. And do some testes for desktop-capturing, when the sender side click the "Share Desktop!" from the right corner of chrome, there will be a pop-up window (Desktop sharing - Desktop sharing using desktopCapture APIs) and we can select what we are going share. The receiver side can then receive the stream. I have observed some small issues when trying this function.

  1. when sender clcik "Share Desktop!" button and start to share, two situations would happen a. receiver side is receiving the stream (one more chrome tap will be generated in sender side -->chrome-extension://bbikikajkaakfifakeddoccnlgljkemn/_generated_background_page.html), then the sender click STOP button on the right corner, it will not stop but pop-up another window for you to select. If you close the additional generated chrome tap first and click the stop button then everything works fine. b. no one is receiving the data, then the sender click the stop button and everything works correctly.
  2. some application we may not enlarge it to full screen, however if sender share it, the receiver side will always fit to full screen that makes the display looks unreasonalbe, is that possible to display it (in receiver) with original size (from sender side). sender Sender choose skype to share.

receiver What we will see in Receiver side.

Thanks for your great works. Albert

muaz-khan commented 10 years ago

We may need to use chrome.desktopCapture.cancelChooseDesktopMedia to stop sharing. I'll install Beta channel soon so I can test and fix it!

P.S. You may install both desktopCapture and tabCapture extensions; both are using same "ids". Please replace following file in the desktopCapture extension:

https://www.webrtc-experiment.com/desktop-sharing/desktop-capturing.js