search

muaz-khan / WebRTC-Experiment

WebRTC, WebRTC and WebRTC. Everything here is all about WebRTC!!
https://www.webrtc-experiment.com/
MIT License
11.75k stars 3.95k forks source link

MediaStreamRecorder.getBlob() is missing? #490

Closed bumi001 closed 7 years ago

bumi001 commented 7 years ago

Hi, This is an excellent package. I was reading the code and noticed that MRecordRTC.getBlob() calls audioRecorder.getBlob(), videRecorder.getBlob() and gifRecorder.getBlob(). However, MediaStreamRecorder.getBlob() is not defined. It is a simple function to define. But, I thought I will bring it to your attention.

muaz-khan commented 7 years ago

It is RecordRTC level function, however you can easily define it as well: dev/MediaStreamRecorder.js:

this.getBlob = function() {
    return this.blob;
};

Or in your HTML file (without modifying the MediaStreamRecorder.js):

MediaStreamRecorder.prototype.getBlob = function() {
    return this.blob;
};
bumi001 commented 7 years ago

Oh! You are right. Thank you.