search

mubaidr / vite-vue3-browser-extension-v3

Another vite powered web extension (chrome, firefox, etc.) starter template.
481 stars 63 forks source link

Source files (.ts) in dist folder #55

Closed ultimateshadsform closed 9 months ago

ultimateshadsform commented 9 months ago

Why does it generate src folder inside dist folder? Can it be fixed? image

mubaidr commented 9 months ago

You are right, this is bug in vite config. Currently the build system outputs ts files to dist/src directory too, which are not required.

I will look into this issue.

mubaidr commented 9 months ago

should be fixed in: https://github.com/mubaidr/vite-vue3-chrome-extension-v3/commit/e171644c05793efdbf23b5b615ad81d40f681c9f

ultimateshadsform commented 9 months ago

I just cloned a new repo and it still has the src folder in the dist folder: image

Should it be like that?

I tried installed pnpm instead of yarn but it still created the dist folder in src

mubaidr commented 9 months ago

I just cloned a new repo and it still has the src folder in the dist folder: image

Should it be like that?

I tried installed pnpm instead of yarn but it still created the dist folder in src

src directory does exists and it's not a problem. We have html files included from src directory. So this is fine.

We should not have any extra (or non compiled files), which has been fixed in latest commit.

ultimateshadsform commented 9 months ago

Ahh okay!

Just wondering if it's possible to change the name of src to another name such as dist or something?

I could always just do a script anyways.

But thank you!

mubaidr commented 9 months ago

This should be possible, I will look into this.

ultimateshadsform commented 9 months ago

It's not really a big deal but I appreciate it!

It's just weird to me to have it named src in production.