mubaris / curiosity

Find Amazing Github :octocat: Projects :zap:
https://mubaris.github.io/curiosity/
247 stars 66 forks source link

Add some tooling. #15

Closed alejandronanez closed 7 years ago

alejandronanez commented 7 years ago

What about adding some eslint / prettier / .editorconfig or maybe some build system?

I'll be down for helping with some of those.

Thanks!

And great project BTW

mubaris commented 7 years ago

Thanks for the suggestion @alejandronanez. Actually, I was planning to setup Travis CI for now. And I'm always welcome to contributions. Send a PR.

alejandronanez commented 7 years ago

Sounds good!

Will do then! On Thu, May 25, 2017 at 6:11 AM Mubaris NK notifications@github.com wrote:

Thanks for the suggestion @alejandronanez https://github.com/alejandronanez. Actually, I was planning to setup Travis CI for now. And I'm always welcome to contributions. Send a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mubaris/curiosity/issues/15#issuecomment-303985329, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcYUjyKsu_O4Y8gsodmZf5N7guyy8ofks5r9WHFgaJpZM4Nlqp- .

mubaris commented 7 years ago

@alejandronanez Maybe you wanna checkout coala to combine ESlint & csslint.

If you're working on it, make a new branch for it. Then send PR. :smile:

alejandronanez commented 7 years ago

Cool! Will check that out! On Thu, May 25, 2017 at 8:32 AM Mubaris NK notifications@github.com wrote:

@alejandronanez https://github.com/alejandronanez Maybe you wanna checkout coala https://github.com/coala/coala to combine ESlint & csslint.

If you're working on it, make a new branch for it. Then send PR. 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mubaris/curiosity/issues/15#issuecomment-304010801, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcYUvsWJ_P1zFr7F112KaVQjkK7638Vks5r9YLhgaJpZM4Nlqp- .

raulvillares commented 7 years ago

Is it possible that some of those new tooling changed some varibables (var or let keyword) to constants (const keyword) ?

For example: const projectsPerPage at main.js can't be modified from languageSelector.js (It was a var projectsPerPage at previous commit). I'm fixing it for isse #18 but I'm afraid it would happen again.

This is another problem of the current lack of modularization (see issue #17 )

mubaris commented 7 years ago

I'm working on #17 , I think I will use webpack

If you declare varibles on the top, it won't be an issue. I think that's okay. Then you can declare var. If you want to declare var in the middle of other code, use "no-var": "off" in .eslintrc.json

alejandronanez commented 7 years ago

I think the change from var->const was possible. And yes that's a problem of having globals leaking all over the place. Maybe a quick search/replace to fix this in the short term. :(