Allow users to add and remove usernames

mubaris / curiosity

Find Amazing Github :octocat: Projects :zap:

https://mubaris.github.io/curiosity/

247 stars 66 forks source link

Allow users to add and remove usernames #16

Closed maiquynhtruong closed 7 years ago

maiquynhtruong commented 7 years ago

This is for issue #6 We can add and remove usernames dynamically. However, changes are not saved. The username array is in usernames.js. I was thinking of modifying that file but could not find a way to do that with Javascript. I hope you could review this PR and let me know how I can further improve it.

mubaris commented 7 years ago

This PR looks clean. I have few suggestions.

Use different colors for Language selection and Username selections. Preferably Orange color I used for to show repository details
Reduce the font of both Language & Username selctions

Then I will merge this. Thank you :+1:

raulvillares commented 7 years ago

@maiquynhtruong To save changes one possibility is store the usernames with localStorage just like the access token.

Though to get real persistence some database system should be used. @mubaris I don't know if that beyond the project's scope...

mubaris commented 7 years ago

@raulvillares @maiquynhtruong We can use LocalStorage for now. But I wanted it to be complete client side web application. So no Databases for now.

mubaris commented 7 years ago

@maiquynhtruong I'm merging this commit for now. I will put another issue to change UI for Selections.

maiquynhtruong commented 7 years ago

I couldn't get to touch a laptop until now. I'll see what I can do for the UI and make another PR