mubaris / curiosity

Find Amazing Github :octocat: Projects :zap:
https://mubaris.github.io/curiosity/
247 stars 66 forks source link

Modules #17

Open raulvillares opened 7 years ago

raulvillares commented 7 years ago

Because the project is growing, interdependencies between different parts are becoming difficult to understand and to change.

Modulalization will help. Options seem to be:

http://eloquentjavascript.net/10_modules.html

mubaris commented 7 years ago

Seems like a good suggestion.

alejandronanez commented 7 years ago

I think UMD and ES modules are the way to go here. :) Ping me if you need something @mubaris

mubaris commented 7 years ago

@alejandronanez I was reading about Webpack for this issue. Is it okay to go with Webpack?

alejandronanez commented 7 years ago

Webpack is a good choice IMO. Webpack is better for apps and Rollup for libraries.

alejandronanez commented 7 years ago

@mubaris let me know if you need any help setting up webpack.

alejandronanez commented 7 years ago

Actually @mubaris if we decide to go with React #35 ...we should ended up rewriting the whole thing...and if that's the case, we can just use create-react-app

Thoughts @raulvillares @mubaris @junedomingo @asiyani @maiquynhtruong ?

raulvillares commented 7 years ago

I don't know much about Webpack, but I've just modularized a small vanilla js puzzle-game with Require.js and I'm happy with that. If vanilla js is still an option for issue #35 maybe we can consider Require?

alejandronanez commented 7 years ago

@raulvillares Just to mention that for the learning experience I find way more valuable to have Webpack in our stack rather than RequireJS. Plus, RequireJS is just a way to manage our dependencies, it doesn't give us all the niceties that webpack offers: ES Modules / ES6 / Treat everything as a module (images, fonts, css) / tree shaking, etc...

raulvillares commented 7 years ago

Yeah, I guessed Webpack was wider than Require.

maiquynhtruong commented 7 years ago

Are we still using webpack or React? Have we decided on something to use yet? Include @asiyani in here

alejandronanez commented 7 years ago

Nothing has been defined yet, we have that conversation split between different threads sighs take a look at #49