mubaris / curiosity

Find Amazing Github :octocat: Projects :zap:
https://mubaris.github.io/curiosity/
247 stars 66 forks source link

Building a backend #20 #40

Closed asiyani closed 7 years ago

asiyani commented 7 years ago

This PR adds Nodejs and MongoDB as the backend to this project. Current functionality for this app is not disturbed. After running yarn start website works as it is working now.

untitled

Please review this folder structure and code. let me know what you guys think? is DB schema properties enough or we need some additional information? I think we should create another issue to discuss schema design.

mubaris commented 7 years ago

@asiyani Cool work man :+1:

@alejandronanez Should I wait for this PR to merge, so that I can work on Webpack

alejandronanez commented 7 years ago

@alejandronanez Should I wait for this PR to merge, so that I can work on Webpack

Yes sir!

alejandronanez commented 7 years ago

@asiyani fix conflicts on index.html and we should be good to go 👍

asiyani commented 7 years ago

I didnt change anything in index.html just moved it to public folder...

On Fri, 2 Jun 2017, 1:36 pm Alejandro Ñáñez Ortiz, notifications@github.com wrote:

@asiyani https://github.com/asiyani fix conflicts on index.html and we should be good to go 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/curiositylab/curiosity/pull/40#issuecomment-305773624, or mute the thread https://github.com/notifications/unsubscribe-auth/AGz7sOoxkh_CsvCDjmvFtTvIyoCfoRnJks5sAAHLgaJpZM4NtnkN .

alejandronanez commented 7 years ago

I didnt change anything in index.html just moved it to public folder...

Oh well, maybe that's the issue. Anyway we can't merge until that's resolved though :( Let me know if you have any issues with those conflicts maybe I can jump in.

asiyani commented 7 years ago

I need index.html in public folder, otherwise i need to create route for index.html Ideally that file should be in public folder. Do you want me too move it to root for now just to merge PR.and then we move it back to public folder?

alejandronanez commented 7 years ago

What merge conflict are you seeing? Feel free to change whatever you think is necessary to solve the conflict so we can merge your pr. On Fri, Jun 2, 2017 at 7:52 AM Ashok notifications@github.com wrote:

I need index.html in public folder, otherwise i need to create route for index.html Ideally that file should be in public folder. Do you want me too move it to root for now just to merge PR.and then we move it back to public folder?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/curiositylab/curiosity/pull/40#issuecomment-305776947, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcYUk0ekBF1VnDGk1ugDbico3AUbgAdks5sAAV5gaJpZM4NtnkN .

mubaris commented 7 years ago

@asiyani You moved the index.html to public folder. After I made a change in the original index.html. Therefore, the git mv didn't work properly. If you move the new index.html to public folder, it might work.

Thoughts @alejandronanez

alejandronanez commented 7 years ago

Yeah that makes sense! On Fri, Jun 2, 2017 at 9:04 AM Mubaris NK notifications@github.com wrote:

@asiyani https://github.com/asiyani You moved the index.html to public folder. After I made a change in the original index.html. Therefore, the git mv didn't work properly. If you move the new index.html to public folder, it might work.

Thoughts @alejandronanez https://github.com/alejandronanez

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/curiositylab/curiosity/pull/40#issuecomment-305797426, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcYUpRTSHbqwry-C4Pr8Tes_RxxFr8Iks5sABZfgaJpZM4NtnkN .

asiyani commented 7 years ago

conflicts are now resolved.

alejandronanez commented 7 years ago

Good stuff boys