search

mubaris / curiosity

Find Amazing Github :octocat: Projects :zap:
https://mubaris.github.io/curiosity/
247 stars 66 forks source link

ESLINT errors down to zero! #43

Open alejandronanez opened 7 years ago

alejandronanez commented 7 years ago

We can do this gradually!

Pre requisites.

mubaris commented 7 years ago

Yeah, it should be done.

alejandronanez commented 7 years ago

I think it would be nice to get rid of aaaaall the eslint errors (I think we have a TON). But doing that in one PR maybe too much. I'm ok if we do this gradually, one PR per file or something like that!

For this to be a thing, we need #17 to be merged in V2 first. BTW

mubaris commented 7 years ago

@alejandronanez Since I'm having some issues, #17 might take more time to finish. I'll try to send a PR as soon as I can.

alejandronanez commented 7 years ago

@mubaris yeah don't feel rushed about it. I just had this on my mind and wanna make sure I don't forget!

mubaris commented 7 years ago

Cool

jearl4 commented 7 years ago

Hope y'all don't mind if I ran eslint and cleaned up a few of the errors. Have a PR out there with the changes and will start work on the emoji file later.

Suneet-M commented 6 years ago

Are all the errors resolved? Or can I contribute as well?

paulopacitti commented 4 years ago

is this issue still open? Can I contribute?

devcer commented 4 years ago

I would like to work on this. Can you assign this to me?

mehargiri commented 1 year ago

Is this issue still open? I want to contribute, can you assign this to me?

ASP124 commented 1 year ago

Hello, Is this issue still open to be resolved or can it be assigned to me?