search

mubaris / curiosity

Find Amazing Github :octocat: Projects :zap:
https://mubaris.github.io/curiosity/
244 stars 65 forks source link

Settings button isn't working on chrome #47

Closed mubaris closed 7 years ago

mubaris commented 7 years ago

The settings button was introduced in #41

It's not working on Chrome in our fork. But the original fork is working. We have to fix ASAP.

Maybe @vvvdeep or @maiquynhtruong can work on this

maiquynhtruong commented 7 years ago

Sure I'll take a look

mubaris commented 7 years ago

@maiquynhtruong What is the progress on this?

maiquynhtruong commented 7 years ago

I just looked at that now and it seems like an easy fix. So I'll make a PR shortly. The link to the original fork is not working so I initialize usernames array in localStorage to the USERNAMES array.

maiquynhtruong commented 7 years ago

Is this still an issue? Should we close it? @mubaris

mubaris commented 7 years ago

We should close it. Next time you send PR for issues, write closes #issueNumber or fixes #issueNumber in the description.

Closing issues via commit messages