Remove scipy from iridium_extractor_flowgraph.py?

muccc / gr-iridium

Iridium burst detector and demodulator.

372 stars 81 forks source link

Remove scipy from iridium_extractor_flowgraph.py? #190

Closed jmfriedt closed 7 months ago

jmfriedt commented 8 months ago

Is the import scipy in https://github.com/muccc/gr-iridium/blob/master/python/iridium_extractor_flowgraph.py needed? I have removed it and the flowgraph seeems to run happily. Removing scipy removes a huge dependency for running gr-iridium on embedded boards (e.g. Raspberry Pi 4) running a Buildroot generated operating system.

Sec42 commented 8 months ago

I seem to remember that it was needed for some debugging output/feature. Checking the git history I can't recall any details though. Maybe @schneider42 remembers something?

schneider42 commented 7 months ago

This must be a leftover from the pure Python implementation. I'm going to remove it.

schneider42 commented 7 months ago

Pushed the change directly to master. Thanks.