search

muccc / iridium-toolkit

A set of tools to parse Iridium frames
477 stars 111 forks source link

add channelized frequency and signal level to acars output #113

Closed rpatel3001 closed 3 months ago

rpatel3001 commented 5 months ago

for use with https://github.com/rpatel3001/docker-gr-iridium-toolkit and https://github.com/sdr-enthusiasts/docker-acarshub

Sec42 commented 5 months ago

Can you provide some more reason/rationale for this? The channelize is a "guess" - it will be off by +/- 1 channel due to doppler shift, so I don't think it is very useful to propagate that to users.

rpatel3001 commented 5 months ago

I just like having the data in my acarshub stats and I think others will too.

Also, I think having a +/- 1 channel frequency guess is better than not having any frequency data.

Sec42 commented 5 months ago

I'd rather propagate the raw frequency than a "wrong" channel. Would that be acceptable for you?

rpatel3001 commented 5 months ago

That would be fine, we can channelize externally (to limit how long the frequency list in acarshub gets)

I can update the PR in a bit.

rpatel3001 commented 3 months ago

good to merge?