muccc / iridium-toolkit

A set of tools to parse Iridium frames
482 stars 112 forks source link

improve reassembler for broken input #22

Closed Sec42 closed 7 years ago

Sec42 commented 7 years ago

The reassambler dies on unparseable input lines. It should output the offending line and possibly just carry on with the rest of the input.

Example error: pypy reassembler.py -i iridium-packets.txt -m lap Traceback (most recent call last): File "reassembler.py", line 395, in zx.run(fileinput.input(ifile)) File "reassembler.py", line 81, in run res=self.filter(line) File "reassembler.py", line 104, in filter q=super(ReassembleIDA,self).filter(line) File "reassembler.py", line 92, in filter q.typ,q.name,q.time,q.frequency,q.confidence,q.level,q.symbols,q.uldl,q.data=line.split(None,8) ValueError: expected length 9, got 7

Sec42 commented 7 years ago

Fixed in 5fa0af2