search

muccc / iridium-toolkit

A set of tools to parse Iridium frames
477 stars 111 forks source link

ACARS JSON to airframes.io #95

Closed kevinelliott closed 1 year ago

kevinelliott commented 1 year ago

This builds on previous work I did to add JSON output to the ACARS parser. It augments the output to be in the format that Airframes is expecting, and also adds a script that can be piped to in order to send the output. The sender script also supports having additional remote outputs.

Example usage:

$ export PYTHONUNBUFFERED=x; ./reassembler.py -i zmq: -m acars -a json --station YOUR_STATION_IDENT | ./iridium-acars-to-airframes.py

In order to send to additional outputs, simply add -o tcp:hostname:port as many times to the iridium-acars-to-airframes.py command.

Sec42 commented 1 year ago

Thanks for the code. The fact that you have a station override bit in the airframes script makes me think about weather the specific json structure field mapping should maybe be moved over there. Let me know if you have an argument either way, otherwise i'll think about it for a bit.

kevinelliott commented 1 year ago

Thanks for the code. The fact that you have a station override bit in the airframes script makes me think about weather the specific json structure field mapping should maybe be moved over there. Let me know if you have an argument either way, otherwise i'll think about it for a bit.

I don't have a compelling argument either way. It was originally put there just in case someone wanted to run multiple instances and have different station ids, but ultimately I think that isn't very beneficial (as it would really just end up sending the same data for multiple station ids for no reason).

Sec42 commented 1 year ago

Turns out I currently don't have the energy to do any changes. Sorry for the delay. Is this still the current version to be merged?

kevinelliott commented 1 year ago

Turns out I currently don't have the energy to do any changes. Sorry for the delay. Is this still the current version to be merged?

Yes, that would be great! Happy to iterate and add improvements after.

kevinelliott commented 1 year ago

@Sec42 merge away!

Sec42 commented 1 year ago

merged