ccgbuildbot
commented
8 years ago [author="lrender", created="Mon, 24 Jun 2013 11:44:49 +0800"]
Currently Yabi uses external library ccg-makoloader to render mako templates.
The ccg library ccg-makoloader ( version 0.2.4 ) library uses django.contrib.admin.templatetags.adminmedia.admin_media_prefix function in the makotemplate module to set location of admin media for all template contexts. The adminmedia module has been removed in Django 1.5.
There are two fixes:
a) Remove dependancy on mako templates in Yabi
b) Create a new version of ccg-makeloader library compatible with Django 1.5
a) Would require converting 28 mako templates to pure Django.
b) Just needs importing settings from django.conf in the module housing the Base Mako Template class.
After discussion with Adam, plan is to do b) for this ticket and create a separate ticket for the ultimate removal/conversion of the Mako templates to pure Django.
[reporter="lrender", created="Fri, 21 Jun 2013 10:18:15 +0800", resolved="Tue, 25 Jun 2013 14:47:13 +0800"]
After upgrade to Django 1.5.1
YABI django.request:ERROR:2013-06-21 09:52:47,283:base.py:212:handle_uncaught_exception Internal Server Error: /login/
Traceback (most recent call last):
File "/usr/local/src/virt_yabiadmin/lib/python2.6/site-packages/django/core/handlers/base.py", line 115, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/usr/local/src/yabiadmin/yabiadmin/yabifeapp/views.py", line 175, in login
return render_to_response('fe/login.html',
{'h':webhelpers, 'form':form, 'url':None, 'error':error, 'show_dev_warning':show_dev_warning}
)
File "/usr/local/src/virt_yabiadmin/lib/python2.6/site-packages/django/shortcuts/_init_.py", line 29, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)
File "/usr/local/src/virt_yabiadmin/lib/python2.6/site-packages/django/template/loader.py", line 170, in render_to_string
t = get_template(template_name)
File "/usr/local/src/virt_yabiadmin/lib/python2.6/site-packages/django/template/loader.py", line 146, in get_template
template, origin = find_template(template_name)
File "/usr/local/src/virt_yabiadmin/lib/python2.6/site-packages/django/template/loader.py", line 129, in find_template
loader = find_template_loader(loader_name)
File "/usr/local/src/virt_yabiadmin/lib/python2.6/site-packages/django/template/loader.py", line 98, in find_template_loader
raise ImproperlyConfigured('Error importing template source loader %s: "%s"' % (loader, e))
ImproperlyConfigured: Error importing template source loader ccg.template.loaders.makoloader.filesystem.Loader: "No module named adminmedia"
REASON:
Django 1.5 removed module adminmedia