feedbacks

[wiekern]

1. change the style of pie chart

   • remove the shadow of pie chart, so that good to read.

2. overlapped piecharts

   • remove all components from pie chart layout, then generate new pie charts.

3. Simple mode change F1 to TPR, and add explanation. Show scenario targets.

4. the label of pie chart on result site is overflowed.

5. (back to config view from detector view)

6. The titles of target ClimteChange on detector view not centered.

7. remove description of statements, add line break for long text if necessary.

8. add targets formatting for grids description on detector view.

9. advanced settings under expert mode

   • model sensitivity
   • coverage should be away from "analysis" button.

[wiekern]

Answer to 5. (back to config view from detector view)

If we have a back button on each site, it is good that make the back button fix in menu bar, then we don't need to write repeat code for back to last view. But vaadin does not support this feature, see below https://github.com/vaadin/framework/issues/2520. Thus, we should do a work around.

[wiekern]

Answer to 1. change the style of pie chart

already adjusted the style. Now it looks like as below

[wiekern]

Answer to 2. overlapped piecharts Each time go to a site the content of layout which includes charts should be cleaned. Done.

[wiekern]

Answer to 4. the label of pie chart on result site is overflowed Due to the width of pie charts are fixed, if the viewport of browser is not enough broad containing all content of pie charts, some content on the edge will be overflow and not seen. ps: https://github.com/vaadin/framework/issues/3070

Optimise: dynamically calculate the width of these pie charts on result view, if user don't resize the browser, all contents can be shown.

[wiekern]

Answer to 6. The titles of target ClimteChange on detector view not centered Everything looks fine on my laptop(Mac OS). It seems that different Fonts exist on each operating system. Our project is deployed under Linux system. Probably we could try to set center alignment manually likechart.getTitle().setHorizontalAlignment(HorizontalAlignment.CENTER);

[wiekern]

Answer to 7. remove description of statements, add line break for long text if necessary. https://github.com/vaadin/vaadin-grid/issues/97

Done

[wiekern]

Answer to 8. add targets formatting for grids description on detector view. Done.

[wiekern]

Answer to 9. advanced settings under expert mode Done. position advanced settings on the leftmost side.

[muchafel]

@wiekern can you open a single issue foreach feedback that has not been fixed yet?

[wiekern]

all issues which not completely done are opened on each issue.