Closed himynamesdave closed 1 month ago
on hold for now, pending further research:
https://dogesec.slack.com/archives/D05L8JEAM1N/p1725893585141609
Have updated the spec to reflect expected behaviour.
Have updated the spec for this ticket
https://github.com/muchdogesec/arango_cti_processor/commit/de66810001f251f7f07f39d6753dad38368b9cec
Needed for changes
2 things
My test for this currently fails. I am not sure why.
python3 -m unittest tests/test_12_0_cve_epss.py
My assumption is that the script looks for existing notes, and then updates them. Is this correct.
If so, how does this work: https://github.com/muchdogesec/cve2stix/issues/26#issuecomment-2401362879
My assumption is that the script looks for existing notes, and then updates them. Is this correct.
No, it doesn't look for existing notes... It just creates a new note if there's an update
If so, how does this work: https://github.com/muchdogesec/cve2stix/issues/26#issuecomment-2401362879
It creates a Note object if and only if the epss data exists
@fqrious so why is the test failing?
The spec didn't mention creating a relationship for it. I just thought the embedded object_refs
would be enough
I think this is the problem
No, it doesn't look for existing notes... It just creates a new note if there's an update
The point of this ticket is that a user can get a historic record of EPSS scores inside the note.
So whenever this update mode is run, the script adds more data for the current day (if it not already present) in the note. This way they can see the changes in EPSS over time
The function to create new notes on updates is also correct, but only half the task.
from my understanding, that is already how it works. You should probably update the spec if you want something different
but then why aren't the notes in the test being updated?
python3 -m unittest tests/test_12_0_cve_epss.py
Because a note is a vertex, so the test is wrong
https://github.com/muchdogesec/arango_cti_processor/blob/embedded-relationship-tests/docs/cve-epss.md