muckSponge / MaterialFox

A Material Design-inspired userChrome.css theme for Firefox
MIT License
1.94k stars 149 forks source link

Unchecked checkboxes should have an icon #232

Open codic12 opened 4 years ago

codic12 commented 4 years ago

Sanity checks (must complete)

Manjaro KDE with the latest Firefox 76. An unchecked checkbox looks like this: image It should be an empty box a different color from the menu to distinguish that it is a checkbox. Until this is fixed (i don't know how to fix it), I have renamed the popup folder to popupstub so that the css will not find it.

muckSponge commented 4 years ago

I was trying to replicate this behaviour:

image

Material Design spec doesn't really have empty checkboxes in menus, but we don't have to follow it to the letter if people would prefer. I guess there's also no case in the design spec where a single checkbox is used (only what are essentially radios with more than one option), so by that logic they could have checkboxes.

codic12 commented 4 years ago

Yeah, it looks good there, but looks pretty out of place in the MaterialFox context menu. Also, how can i decrease the padding between menu items?