search

mudcoders / guildmud

A SocketMUD-based Multi-User Dungeon built and managed by the members of The MUD Coders Guild.
MIT License
26 stars 12 forks source link

Adds gmcp support #24

Closed LiquidityC closed 6 years ago

LiquidityC commented 6 years ago

I added an embryo of GMCP support. It's usable and works. I'd love some comments. And if it's approved I think it's up to someone with a bigger perspective on the project to decide how to use it. Some sort of JSON module would likely help.

Please get back with any improvement suggestions etc. I'm not assuming this will go straight into the devel branch ;)

zachflower commented 6 years ago

Thanks for the contribution @LiquidityC! The code itself looks solid, although I haven't had a chance to test it myself (I will prioritize that as soon as I get a chance). As we add features, I am curious how everyone feels about using isolated header files (in this case using a gmcp.h, rather than the catchall mud.h).

@rogersm @xenith Any opinion on that?

xenith commented 6 years ago

I agree that smaller header files are generally a better idea. It's a balancing act around too many includes and circular includes.

LiquidityC commented 6 years ago

Want me to separate the gmcp stuff from mud.h to gmcp.h?

rogersm commented 6 years ago

@zachflower only for the 3 gmcp functions? I would say keep them in mud.h for now.

zachflower commented 6 years ago

@rogersm I'm fine with that for now, we could always separate things out in a separate refactor in the future if we were so inclined.

LiquidityC commented 6 years ago

I added the changes but the commits are squashed so the fixes are in the same commit.

zachflower commented 6 years ago

Looks good, thanks so much for the contribution @LiquidityC! If you haven't already joined us on Slack, please pop by (https://slack.mudcoders.com/) we'd love to have you!