Closed flavorjones closed 1 month ago
The workflow in question is https://github.com/flavorjones/mini_portile/actions/runs/9903843042/workflow#L31
Given there have been no changes to Abseil or re2 in the past week that should cause this, I'm not sure what is going on. Looking at your recent downstream runs, there have been changes to the underlying GitHub Actions runner images:
OS | Passing version | Failing version |
---|---|---|
Ubuntu | 20240630.1.0 | 20240708.1.0 |
Windows | 20240630.1.0 | 20240707.1.0 |
macOS | 20240701.9 | 20240707.1 |
Looking at the changes to macOS specifically (given the bump is so small), the suspicious thing to me is the upgrade from CMake 3.29 to 3.30.
Perhaps it is a bug in Abseil resolved by https://github.com/abseil/abseil-cpp/commit/cd7f66cab520e99531979b3fd727a25616a1ccbb?
Weird, ok. I'll ignore it for now, I guess, and hope that it resolves at some point in the future?
Frustratingly, if Abseil 20240116.2 can't be compiled with CMake 3.30 (which was released on 2 July), it'll be broken until there is a new release of Abseil and I upgrade to it.
OK, ignoring for now: https://github.com/flavorjones/mini_portile/pull/148
Yeah, I reproduced this problem on Homebrew after upgrading to CMake 3.30.
I've raised https://github.com/mudge/re2/pull/159 in an attempt to fix this by patching Abseil 20240116.2 with https://github.com/abseil/abseil-cpp/commit/779a3565ac6c5b69dd1ab9183e500a27633117d5.
Now fixed on main
and in re2 2.13.2.
Thank you!
Heyo @mudge, I need to ask for your help to diagnose a thing.
I've been running downstream integration tests in mini_portile2's Github Actions suite for a while, and this week the re2 tests started failing and I don't really understand the failure mode, which appears to be in building abseil.
Example: https://github.com/flavorjones/mini_portile/actions/runs/9903843042/job/27429080214#step:7:60
Any ideas what's going on?