search

mudgen / diamond-1

EIP-2535 Diamonds reference implementation.
MIT License
30 stars 12 forks source link

DiamondCutFacet.sol is NOT standard #3

Closed fulldecent closed 4 years ago

fulldecent commented 4 years ago

At https://github.com/mudgen/diamond-1/blob/1.3.5/contracts/facets/DiamondCutFacet.sol#L13

it is referred that this is the // Standard diamondCut external function.

But actually this is NOT standardized. The standard makes no mention that this function be restricted to OWNER usage.

mudgen commented 4 years ago

Thanks. I removed the comment.