Missing test contracts in 2_diamonds.js

mudgen / diamond-1

EIP-2535 Diamonds reference implementation.

MIT License

30 stars 12 forks source link

Missing test contracts in 2_diamonds.js #7

Closed Walodja1987 closed 3 years ago

Walodja1987 commented 3 years ago

In 2_diamonds.js, const diamondCut part, the test contracts seem to be missing. I would have expected to see the following two elements in the diamondCut array:

[Test1Facet.address, FacetCutAction.Add, getSelectors(Test1Facet)],
[Test2Facet.address, FacetCutAction.Add, getSelectors(Test2Facet)]

mudgen commented 3 years ago

Yes, the test contracts could be added that way. In this case the test contracts are added in this this test script: https://github.com/mudgen/diamond-1/blob/master/test/diamondTest.js#L121