initial hold to edit functionality

mudkipme / MoeMemosAndroid

An app to help you capture thoughts and ideas

http://memos.moe

GNU General Public License v3.0

615 stars 67 forks source link

initial hold to edit functionality #205

Closed jkuhlemann closed 1 week ago

jkuhlemann commented 2 months ago

I'm working on resolving #161 - The basic functionality is there. However, whenever I hold inside the text, onLongPress does not get triggered. Holding anywhere else inside a MemosCard works and correctly triggers the edit screen.

Any ideas to fix this would be greatly appreciated :) I'm currently out of ideas on how to debug this.

ariloc commented 4 weeks ago

Hi, I created a PR at your fork that should fix the issue you were encountering: https://github.com/jkuhlemann/MoeMemosAndroid/pull/1

There I explained better what I could find, and I hope it's what you were looking for.

jkuhlemann commented 2 weeks ago

@mudkipme should be ready to merge with the fix provided by @ariloc 🙏