search

mudpi / mudpi-core

Configurable automation library for linux SBC boards including raspberry pi
https://mudpi.app
275 stars 40 forks source link

Hamburger Menu not clickable on mobile #21

Closed BillyHilly closed 3 years ago

BillyHilly commented 3 years ago

Hello, First off, great work on this, it's awesome! I too am a web developer, and I've thoroughly enjoyed getting to know both Raspberry Pi and MudPi. You did alot of great work under the hood. Very impressive. I hope to be able to contribute to the project in the future. Until then, just wanted to alert you to the an issue I noticed. When I visit my localhost/ site MudPi sets up, on my iPhone 6s the hamburger menu doesn't open / not clickable. I didn't look into it yet, but my guess would be it just needs a position and higher z-index set via CSS. It's like it's behind the main layer and thus unclickable. Anyways, wanted to let you know and also say awesome job!

yeyeto2788 commented 3 years ago

Hey @BillyHilly,

I think this issue should be opened on the assistant repository. But let's wait for @olixr decision on this one.

Would be also helpful if you add more details on how to reproduce the error. Things like:

BillyHilly commented 3 years ago

Thanks @yeyeto2788 Not sure on the Assistant repo since the server/website is part of MudPi. But whichever is most applicable is fine by me — whatever's decided.

I just checked the issue directly on the rPi browser and desktop Chrome/Safari/FF, shrunk the window to mobile size and the hamburger nav shows. Same issue across the board. I noticed a `@click="toggleNav" attribute set on the Hamburger SVG, but it doesn't seem to be working or throwing an error. Not sure I can be of much further help since there's no error and it's JS based (I always use CSS only method for hamburgers). Hope that helps!

SecT0uch commented 3 years ago

Same issue here on Firefox Android. The website seems to be in the ui repo

olixr commented 3 years ago

Yes the UI is under another repo. Closing this issue and we can open it under there.

The menu though is not backed by any javascript action. Its just cosmetic at the moment. The UI is getting a replaced with my internal one when its ready to release. If you want to try and update the UI menu to work though that would be awesome! Otherwise I don't know when I will get to it in favor of the new dashboard in the pipeline.