search

mudrd8mz / moodle-editor_marklar

Markdown friendly editor for Moodle
GNU General Public License v3.0
17 stars 3 forks source link

Does not work and look good if used as a field in database activity #7

Closed wildgirl closed 7 years ago

wildgirl commented 8 years ago

In a database activity, the text area field is narrow (narrower than defined in the field setting) e.g. https://moodle.org/mod/data/edit.php?d=54 This bug only affects you if you're using the marklar text editor.

mudrd8mz commented 8 years ago

Thanks Helen. I think for now I will do the same as I did in admin configuration (for HTML editor admin fields) - that is effectively disable Marklar there. On contrary to TinyMCE or Atto that effectively replace the original textarea field, the Marklar editor tries to enhance it instead. It works well if the editor is part of a moodle form. But it fails elsewhere (not for example that the Preview button does not work in this case, too).

The proper solution for a future version would be to rethink the way how the Marklar is initialised in the page, and make sure it can be safely used anywhere, even out of the moodle forms.

wildgirl commented 8 years ago

I'm not sure it is necessary to disable Marklar there, as you have the option to resize the text area and make it wider. It's only a tiny bug, and when you're used to using Marklar it is distressing to have the HTML editor forced on you.

mudrd8mz commented 7 years ago

I think I have a fix for this. There is no way to provide the Preview feature in the Database activity (due to way how it has text format selector implemented) but it should no longer make the Marklar that narrow.

mudrd8mz commented 7 years ago

Should be fixed in version 0.5.0

wildgirl commented 7 years ago

Thanks David for the fix. It looks fine on moodle.org.