File contents

[alexandru-elisei]

As the code is right now I don't see any way to access the contents of the files after I call $manager->make(). Under these circumstances I cannot write any PHPUnit tests.

May I propose this function for the manager class:

• get_file_content(): returns an array of the type filename => content. It doesn't return the $files property directly because I don't think it's a good idea to expose the internal workings of the manager class (in this case, how the generated files are actually classes).

[alexandru-elisei]

I'm not opposed to having another name for this function. Maybe you think something like get_files() is better (although it might get confused with a getter function for the $files class variable).

[mudrd8mz]

Could the files be in plural as in get_files_content(). For a method get_file_content() I would expect to get the content of a single file.

Otherwise sure, good idea.

[alexandru-elisei]

Done, rebased with the new function name.

Can you merge my branch? I need this function for creating the tests for the other features.

[mudrd8mz]

Looking at the branch, I realised it could be useful to have both: get_file_content($filename) would return the requested file's content (or null). And get_files_content() would return the array as it is now.

[alexandru-elisei]

Do you think a function like get_file_names() might be useful too? Too see which files are generated by the manager?

[mudrd8mz]

yup, why not. just note we should focus on things that are actually needed by the current API consumers.

[mudrd8mz]

Closing for inactivity. Also it seems that most of this now actually exists.