Closed alexandru-elisei closed 3 years ago
I'm not opposed to having another name for this function. Maybe you think something like get_files() is better (although it might get confused with a getter function for the $files class variable).
Could the files be in plural as in get_files_content()
. For a method get_file_content()
I would expect to get the content of a single file.
Otherwise sure, good idea.
Done, rebased with the new function name.
Can you merge my branch? I need this function for creating the tests for the other features.
Looking at the branch, I realised it could be useful to have both: get_file_content($filename)
would return the requested file's content (or null). And get_files_content()
would return the array as it is now.
Do you think a function like get_file_names() might be useful too? Too see which files are generated by the manager?
yup, why not. just note we should focus on things that are actually needed by the current API consumers.
Closing for inactivity. Also it seems that most of this now actually exists.
As the code is right now I don't see any way to access the contents of the files after I call $manager->make(). Under these circumstances I cannot write any PHPUnit tests.
May I propose this function for the manager class: