search

mudrd8mz / moodle-tool_pluginskel

Generator of Moodle plugins skeletons
https://moodle.org/plugins/tool_pluginskel
Other
51 stars 46 forks source link

php_internal_file sets is_moodle_internal to false #10

Closed alexandru-elisei closed 8 years ago

alexandru-elisei commented 8 years ago

In classes/local/skel/php_internal_file.php, on line 49: $this->data['is_moodle_internal'] = false;

Should 'is_moodle_internal' be set to true, as the name of the class suggests?

mudrd8mz commented 8 years ago

Oh yes. I forgot to put it back after developing the require of config.php. well spotted! On Jun 23, 2016 2:19 PM, "Alexandru Elisei" notifications@github.com wrote:

In classes/local/skel/php_internal_file.php, on line 49: $this->data['is_moodle_internal'] = false;

Should 'is_moodle_internal' be set to true, as the name of the class name suggests?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mudrd8mz/moodle-tool_pluginskel/issues/10, or mute the thread https://github.com/notifications/unsubscribe/AAFPR9PKtjA6h9mZGIiiybHjH0TESH_Eks5qOnnlgaJpZM4I8v5Q .

alexandru-elisei commented 8 years ago

Do you think I should also check for the defined('MOODLE_INTERNAL') || die()) line in the PHPUnit tests? I think I should, it's part of the feature being implemented.

mudrd8mz commented 8 years ago

Yes, there should be a test for it so that we have full coverage.