search

mudrd8mz / moodle-tool_pluginskel

Generator of Moodle plugins skeletons
https://moodle.org/plugins/tool_pluginskel
Other
51 stars 46 forks source link

Fix travis configuration #104

Closed Dagefoerde closed 3 years ago

Dagefoerde commented 4 years ago

My contributions in #102 & #103 made apparent that the Travis configuration was not working anymore (Postgres version was too low for master).

I've been meaning to get around to that. And now I have, but there was a complication: Moodle has bumped the required PHPUnit version to 8.5 in the meantime :) So this error followed after changing the Postgres version:

Fatal error: Declaration of tool_pluginskel_atto_testcase::setUpBeforeClass() must be compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void in /home/travis/build/moodle/admin/tool/pluginskel/tests/atto_test.php on line 72

This is now fixed, but also requires limiting PHPUnit tests to a Moodle version that uses PHPUnit 8.5+. Note that there are a few deprecation warnings as well, preparing for PHPUnit 9. They could be tackled in a later change.

Merging this PR will make #102 and #103 run :)

mudrd8mz commented 3 years ago

Thank you Jan for the contribution and sorry for ignoring it for so long.

I am going to close this now as we have switched over to Github actions meanwhile.