search

mudrd8mz / moodle-tool_pluginskel

Generator of Moodle plugins skeletons
https://moodle.org/plugins/tool_pluginskel
Other
51 stars 46 forks source link

Cli_script feature #35

Closed alexandru-elisei closed 8 years ago

alexandru-elisei commented 8 years ago

Modified based on the comments in #29.

After this gets merged I'll remove the 'all' feature from all the PHPUnit files.

mudrd8mz commented 8 years ago

Note, I am once again worried about adding things like support for $this->recipe['cli_script'] without having a single place (recipe-dist.yaml) where every single supported value would be put and documented. It will be a painful, boring and error prone process to construct such a file later.

Edit: The file cli/example.yaml landed in another pull request, thanks

mudrd8mz commented 8 years ago

Can you please rebase to avoid conflicts.

alexandru-elisei commented 8 years ago

Rebased.

mudrd8mz commented 8 years ago

May I ask for yet another modification please. Can the recipe file option read cli_scripts (plural) to be consistent with other keywords we use there to describe lists (such as capabilities, message_providers, strings etc).

Also, this patch should probably remove the note "Not implemented yet." from the referential example.yaml recipe.

mudrd8mz commented 8 years ago

I am going to close this pull request now. Can you please make a new one with the suggested changes. I would like to test the newly set up travis integration with https://travis-ci.org/mudrd8mz/moodle-tool_pluginskel/ which should automatically run the unit tests and coding style checkers for every new pull request. Thanks for understanding.