search

mudrd8mz / moodle-tool_pluginskel

Generator of Moodle plugins skeletons
https://moodle.org/plugins/tool_pluginskel
Other
51 stars 46 forks source link

Use verify_strings_exist() #52

Closed alexandru-elisei closed 8 years ago

alexandru-elisei commented 8 years ago

The error is the same setUpBeforeClass() function name error.

Is there some way for me to fix this?

mudrd8mz commented 8 years ago

I am not aware of a way to deal with this one particular false travis error on our side. The only option I know is to ignore all tests from all the checks. We can probably do that.

alexandru-elisei commented 8 years ago

No, those tests are important. I can live with always having to check the cause of the error for each pull request.

mudrd8mz commented 8 years ago

I am not saying the tests won't be executed. But the files in tests/* will be skipped from the checks like syntax etc. I committed this temporary fix already in our travis file. I also opened https://github.com/moodlehq/moodle-local_codechecker/pull/31 for the permanent and proper solution. Once the code checker fix is accepted and deployed, we will undo our workaround.

alexandru-elisei commented 8 years ago

Oh, I see now. Yes, this is a good idea.

mudrd8mz commented 8 years ago

https://travis-ci.org/mudrd8mz/moodle-tool_pluginskel/jobs/144418877 started to pass again.