search

mudrd8mz / moodle-tool_pluginskel

Generator of Moodle plugins skeletons
https://moodle.org/plugins/tool_pluginskel
Other
51 stars 46 forks source link

Rename the 'strings' feature to 'lang_strings' #60

Closed alexandru-elisei closed 8 years ago

alexandru-elisei commented 8 years ago

If I use the variable name 'strings' for a form element then the web page produces a memory overflow because Moodle will call the function optional_param('strings', 0, PARAM_INT) (file lib/moodlelib.php, line 6843) repeatedly when it constructs the moodleform.

This behaviour is present in the commit 'Treat feature variables consistently', simply uncomment the lines 117 to 120 from classes/local/util/manager.php (this will add the variable 'strings' to the list of feature variables).

I propose renaming the feature to 'lang_strings'.

alexandru-elisei commented 8 years ago

After our converstion we have decided to rename the feature to 'lang_strings'.