search

mudrd8mz / moodle-tool_pluginskel

Generator of Moodle plugins skeletons
https://moodle.org/plugins/tool_pluginskel
Other
51 stars 46 forks source link

Upgrade.php not working when building a mod #90

Closed luukverhoeven closed 5 years ago

luukverhoeven commented 6 years ago

Thanks for building this plugin in the first place. Its very handy way to start building a plugin. I found a small issue, the component name used in upgrade.php is incorrect when you building a mod.

This should not contain mod_name but only the name. I think only mod should be without the plugin type.

image

--

image

image

luukverhoeven commented 6 years ago

hmm maybe I did something wrong, on multiple places there is mod_ where it shouldn't be.

mudrd8mz commented 6 years ago

Thanks Luuk. You are right. I can confirm that in case of activity modules, the "mod" should not be here. This is a known legacy from early versions of Moodle. Activity modules were the first plugins for it and there was no convention of using the type prefix by that time. So in many places, activity modules are not supposed to provide the "mod" prefix, and many places where they are.

Meanwhile, please fix your plugin's code manually. Than you for letting me know about this.